removed experimental status from many events, attributes and methods

mojolicious · Jan 1, 2012 · da55fb3 · da55fb3
1 parent c578195
commit da55fb3
Show file tree

Hide file tree

Showing 14 changed files with 34 additions and 93 deletions.
diff --git a/Changes b/Changes
@@ -4,6 +4,26 @@ This file documents the revision history for Perl extension Mojolicious.
         - Deprecated Test::Mojo->max_redirects.
         - Removed exprimental status from respond_to method in
           Mojolicious::Controller.
+        - Removed experimental status from error event in Mojo::UserAgent.
+        - Removed experimental status from connect_timeout attribute in
+          Mojo::UserAgent.
+        - Removed experimental status from connection event in
+          Mojo::Transaction.
+        - Removed experimental status from upgrade event in
+          Mojo::Asset::Memory.
+        - Removed experimental status from auto_upgrade and max_memory_size
+          attributes in Mojo::Asset::Memory.
+        - Removed experimental status from part event in
+          Mojo::Content::MultiPart.
+        - Removed experimental status from upgrade event in
+          Mojo::Content::Single.
+        - Removed experimental status from auto_upgrade attribute in
+          Mojo::Content::Single.
+        - Removed experimental status from body event in Mojo::Content.
+        - Removed experimental status from mojo_lib_dir and slurp_rel_file
+          methods in Mojo::Home.
+        - Removed experimental status from message event in Mojo::Log.
+        - Removed experimental status from contains method in Mojo::Path.
         - Removed test_server method from Test::Mojo.
         - Renamed test_server method in Mojo::UserAgent to app_url.
         - Improved RFC 6265 compliance of generated request headers.

diff --git a/lib/Mojo/Asset/Memory.pm b/lib/Mojo/Asset/Memory.pm
@@ -91,8 +91,7 @@ L<Mojo::Asset::Memory> can emit the following events.
     my ($mem, $file) = @_;
   });
 
-Emitted when asset gets upgraded to a L<Mojo::Asset::File> object. Note that
-this event is EXPERIMENTAL and might change without warning!
+Emitted when asset gets upgraded to a L<Mojo::Asset::File> object.
 
   $mem->on(upgrade => sub {
     my ($mem, $file) = @_;
@@ -110,8 +109,7 @@ implements the following new ones.
   $mem        = $mem->auto_upgrade(1);
 
 Try to detect if content size exceeds C<max_memory_size> limit and
-automatically upgrade to a L<Mojo::Asset::File> object. Note that this
-attribute is EXPERIMENTAL and might change without warning!
+automatically upgrade to a L<Mojo::Asset::File> object.
 
 =head2 C<max_memory_size>
 
@@ -120,8 +118,7 @@ attribute is EXPERIMENTAL and might change without warning!
 
 Maximum asset size in bytes, only attempt upgrading to a L<Mojo::Asset::File>
 object after reaching this limit, defaults to the value of
-C<MOJO_MAX_MEMORY_SIZE> or C<262144>. Note that this attribute is
-EXPERIMENTAL and might change without warning!
+C<MOJO_MAX_MEMORY_SIZE> or C<262144>.
 
 =head1 METHODS
 

diff --git a/lib/Mojo/Content.pm b/lib/Mojo/Content.pm
@@ -144,13 +144,6 @@ sub is_parsing_body { (shift->{state} || '') eq 'body' }
 
 sub leftovers { shift->{buffer} }
 
-# DEPRECATED in Smiling Face With Sunglasses!
-sub on_read {
-  warn
-    "Mojo::Content->on_read is DEPRECATED in favor of Mojo::Content->on!\n";
-  shift->on(read => shift);
-}
-
 sub parse {
   my $self = shift;
 
@@ -432,8 +425,7 @@ L<Mojo::Content> can emit the following events.
     ...
   });
 
-Emitted once all headers have been parsed and the body starts. Note that this
-event is EXPERIMENTAL and might change without warning!
+Emitted once all headers have been parsed and the body starts.
 
   $content->on(body => sub {
     my $content = shift;

diff --git a/lib/Mojo/Content/MultiPart.pm b/lib/Mojo/Content/MultiPart.pm
@@ -256,8 +256,7 @@ emit the following new ones.
     ...
   });
 
-Emitted when a new L<Mojo::Content::Single> part starts. Note that this event
-is EXPERIMENTAL and might change without warning!
+Emitted when a new L<Mojo::Content::Single> part starts.
 
   $multi->on(part => sub {
     my ($multi, $single) = @_;

diff --git a/lib/Mojo/Content/Single.pm b/lib/Mojo/Content/Single.pm
@@ -95,7 +95,6 @@ emit the following new ones.
   });
 
 Emitted when content gets upgraded to a L<Mojo::Content::MultiPart> object.
-Note that this event is EXPERIMENTAL and might change without warning!
 
   $single->on(upgrade => sub {
     my ($single, $multi) = @_;
@@ -122,8 +121,7 @@ C<auto_upgrade> enabled.
   $single     = $single->auto_upgrade(0);
 
 Try to detect multipart content and automatically upgrade to a
-L<Mojo::Content::MultiPart> object, defaults to C<1>. Note that this
-attribute is EXPERIMENTAL and might change without warning!
+L<Mojo::Content::MultiPart> object, defaults to C<1>.
 
 =head1 METHODS
 

diff --git a/lib/Mojo/Home.pm b/lib/Mojo/Home.pm
@@ -201,8 +201,7 @@ List all files in directory and subdirectories recursively.
 
   my $path = $home->mojo_lib_dir;
 
-Path to C<lib> directory in which L<Mojolicious> is installed. Note that this
-method is EXPERIMENTAL and might change without warning!
+Path to C<lib> directory in which L<Mojolicious> is installed.
 
 =head2 C<parse>
 
@@ -226,8 +225,7 @@ Generate absolute path for relative file.
 
   my $string = $home->slurp_rel_file('foo/bar.html');
 
-Read all file data at once. Note that this method is EXPERIMENTAL and might
-change without warning!
+Read all file data at once.
 
 =head2 C<to_string>
 

diff --git a/lib/Mojo/Log.pm b/lib/Mojo/Log.pm
@@ -124,8 +124,7 @@ L<Mojo::Log> can emit the following events.
     ...
   });
 
-Emitted when a new message gets logged. Note that this event is EXPERIMENTAL
-and might change without warning!
+Emitted when a new message gets logged.
 
   $log->unsubscribe('message');
   $log->on(message => sub {

diff --git a/lib/Mojo/Message.pm b/lib/Mojo/Message.pm
@@ -298,21 +298,6 @@ sub leftovers { shift->content->leftovers }
 
 sub max_line_size { shift->headers->max_line_size(@_) }
 
-# DEPRECATED in Smiling Face With Sunglasses!
-sub on_finish {
-  warn
-    "Mojo::Message->on_finish is DEPRECATED in favor of Mojo::Message->on!\n";
-  shift->on(finish => shift);
-}
-
-# DEPRECATED in Smiling Face With Sunglasses!
-sub on_progress {
-  warn <<EOF;
-Mojo::Message->on_progress is DEPRECATED in favor of Mojo::Message->on!
-EOF
-  shift->on(progress => shift);
-}
-
 sub param {
   my $self = shift;
   $self->{body_params} ||= $self->body_params;

diff --git a/lib/Mojo/Path.pm b/lib/Mojo/Path.pm
@@ -180,8 +180,7 @@ Clone path.
 
   my $success = $path->contains('/foo');
 
-Check if path contains given prefix. Note that this method is EXPERIMENTAL
-and might change without warning!
+Check if path contains given prefix.
 
   # True
   Mojo::Path->new('/foo/bar')->contains('/');

diff --git a/lib/Mojo/Server.pm b/lib/Mojo/Server.pm
@@ -51,13 +51,6 @@ EOF
   return $app;
 }
 
-# DEPRECATED in Smiling Face With Sunglasses!
-sub on_request {
-  warn
-    "Mojo::Server->on_request is DEPRECATED in favor of Mojo::Server->on!\n";
-  shift->on(request => shift);
-}
-
 # "Are you saying you're never going to eat any animal again? What about
 #  bacon?
 #  No.

diff --git a/lib/Mojo/Transaction.pm b/lib/Mojo/Transaction.pm
@@ -47,22 +47,6 @@ sub is_writing {
   return $state ~~ [qw/write write_start_line write_headers write_body/];
 }
 
-# DEPRECATED in Smiling Face With Sunglasses!
-sub on_finish {
-  warn <<EOF;
-Mojo::Transaction->on_finish is DEPRECATED in favor of Mojo::Transaction->on!
-EOF
-  shift->on(finish => shift);
-}
-
-# DEPRECATED in Smiling Face With Sunglasses!
-sub on_resume {
-  warn <<EOF;
-Mojo::Transaction->on_resume is DEPRECATED in favor of Mojo::Transaction->on!
-EOF
-  shift->on(resume => shift);
-}
-
 sub remote_address {
   my ($self, $address) = @_;
 
@@ -125,8 +109,7 @@ L<Mojo::Transaction> can emit the following events.
     ...
   });
 
-Emitted when a connection has been assigned to transaction. Note that this
-event is EXPERIMENTAL and might change without warning!
+Emitted when a connection has been assigned to transaction.
 
 =head2 C<finish>
 

diff --git a/lib/Mojo/Transaction/HTTP.pm b/lib/Mojo/Transaction/HTTP.pm
@@ -91,15 +91,6 @@ sub keep_alive {
   return 1;
 }
 
-# DEPRECATED in Smiling Face With Sunglasses!
-sub on_request {
-  warn <<EOF;
-Mojo::Transaction::HTTP->on_request is DEPRECATED in favor of
-Mojo::Transaction::HTTP->on!
-EOF
-  shift->on(request => shift);
-}
-
 sub server_leftovers {
   my $self = shift;
 

diff --git a/lib/Mojo/UserAgent.pm b/lib/Mojo/UserAgent.pm
@@ -97,14 +97,6 @@ sub need_proxy {
   return 1;
 }
 
-# DEPRECATED in Smiling Face With Sunglasses!
-sub on_start {
-  warn <<EOF;
-Mojo::UserAgent->on_start is DEPRECATED in favor of Mojo::UserAgent->on!
-EOF
-  shift->on(start => shift);
-}
-
 sub post_form {
   my $self = shift;
   $self->start($self->build_form_tx(@_));
@@ -641,8 +633,7 @@ L<Mojo::UserAgent> can emit the following events.
     ...
   });
 
-Emitted if an error happens that can't be associated with a transaction. Note
-that this event is EXPERIMENTAL and might change without warning!
+Emitted if an error happens that can't be associated with a transaction.
 
   $ua->on(error => sub {
     my ($ua, $err) = @_;
@@ -682,8 +673,7 @@ environment variable.
   $ua         = $ua->connect_timeout(5);
 
 Maximum amount of time in seconds establishing a connection may take,
-defaults to C<3>. Note that this attribute is EXPERIMENTAL and might change
-without warning!
+defaults to C<3>.
 
 =head2 C<cookie_jar>
 

diff --git a/t/pod_coverage.t b/t/pod_coverage.t
@@ -7,9 +7,6 @@ plan skip_all => 'Test::Pod::Coverage 1.04 required for this test!'
 plan skip_all => 'set TEST_POD to enable this test (developer only!)'
   unless $ENV{TEST_POD};
 
-# DEPRECATED in Smiling Face With Sunglasses!
-my @sunglasses = (qw/on_progress on_read on_request on_resume on_start/);
-
 # DEPRECATED in Leaf Fluttering In Wind!
 my @leaf = (
   qw/add_hook comment connect connection_timeout is_done keep_alive_timeout/,
@@ -19,4 +16,4 @@ my @leaf = (
 
 # "Marge, I'm going to miss you so much. And it's not just the sex.
 #  It's also the food preparation."
-all_pod_coverage_ok({also_private => ['inet_pton', @leaf, @sunglasses]});
+all_pod_coverage_ok({also_private => [@leaf]});