Do not attempt to change the status on an inbox message which doesn't exist. Fixes bug #12349.

perlDreamer · perlDreamer · commit 2c225f30f531 · 2012-04-02T18:33:38.000-07:00
diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt
@@ -12,6 +12,7 @@
  - fixed: Crud updateFromFormPost
  - fixed: encryptLogin and sslEnabled both need to be true
  - fixed: Cache's setByHTTP method returns content, even when it gets an error in the request.  This gives the SC asset fits.
+ - fixed #12349: Friends invitation error
 
 7.10.24
  - fixed #12318: asset error causes asset manager to fail
diff --git a/lib/WebGUI/Friends.pm b/lib/WebGUI/Friends.pm
@@ -320,7 +320,10 @@ sub rejectAddRequest {
             status  => 'unread',
         });
     }
-    $inbox->getMessage($invite->{messageId})->setStatus('completed');
+    my $invitation = $inbox->getMessage($invite->{messageId});
+    if ($invitation) {
+        $invitation->setStatus('completed');
+    }
     $self->session->db->deleteRow("friendInvitations", "inviteId", $inviteId);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -320,7 +320,10 @@ sub rejectAddRequest {`
`320`	`320`	`status => 'unread',`
`321`	`321`	`});`
`322`	`322`	`}`
`323`		`- $inbox->getMessage($invite->{messageId})->setStatus('completed');`
	`323`	`+ my $invitation = $inbox->getMessage($invite->{messageId});`
	`324`	`+ if ($invitation) {`
	`325`	`+ $invitation->setStatus('completed');`
	`326`	`+ }`
`324`	`327`	`$self->session->db->deleteRow("friendInvitations", "inviteId", $inviteId);`
`325`	`328`	`}`
`326`	`329`