dom/attribute: cleanup code

opal · Feb 6, 2014 · 297750b · 297750b
1 parent 05c61a7
commit 297750b
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 12 deletions.
diff --git a/opal/browser/dom/attribute.rb b/opal/browser/dom/attribute.rb
@@ -4,22 +4,17 @@ module Browser; module DOM
 class Attribute
   include Native
 
-  # Returns true if the attribute is an id.
-  def id?
-    `#@native.isId`
-  end
-
   # @!attribute [r] name
   # @return [String] the name of the attribute
-  def name
-    `#@native.name`
-  end
+  alias_native :name
 
-  # @!attribute [r] value
+  # @!attribute value
   # @return [String] the value of the attribute
-  def value
-    `#@native.value`
-  end
+  alias_native :value
+  alias_native :value=
+
+  # Returns true if the attribute is an id.
+  alias_native :id?, :isId
 end
 
 end; end
diff --git a/spec/dom/attribute_spec.rb b/spec/dom/attribute_spec.rb
@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe Browser::DOM::Attribute do
+  html <<-HTML
+    <div id="lol" class="hue" something="wat"></div>
+  HTML
+
+  describe '#name' do
+    it 'gets the right name' do
+      attr = $document['lol'].attribute_nodes.find { |a| a.name == :id }
+
+      expect(attr.name).to eq(:id)
+    end
+  end
+
+  describe '#value' do
+    it 'gets the right value' do
+      attr = $document['lol'].attribute_nodes.find { |a| a.name == :id }
+
+      expect(attr.name).to eq(:id)
+      expect(attr.value).to eq(:lol)
+    end
+  end
+
+  describe '#value=' do
+    it 'sets the value' do
+      attr = $document['lol'].attribute_nodes.find { |a| a.name == :id }
+
+      expect(attr.name).to eq(:id)
+      expect(attr.value).to eq(:lol)
+      attr.value = :omg
+      expect(attr.value).to eq(:omg)
+    end
+  end
+
+  describe '#id?' do
+    it 'is true for an id attribute' do
+      attr = $document['lol'].attribute_nodes.find { |a| a.name == :id }
+
+      expect(attr.id?).to be_truthy
+    end
+
+    it 'is false for any other attribute' do
+      attr = $document['lol'].attribute_nodes.find { |a| a.name == :class }
+
+      expect(attr.id?).to be_falsy
+    end
+  end
+end