Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

low-level retrieval of jcr content from the low-level binary stores #35

Merged
merged 2 commits into from Mar 12, 2013

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Mar 12, 2013

No description provided.

@cbeer
Copy link
Contributor Author

cbeer commented Mar 12, 2013

@ajs6f @barmintor am I crazy? could there be a better way?

(also, i'm regretting calling it a RepositoryService.. it's probably a "LowLevelStorageService" or something. thoughts?)

@barmintor
Copy link
Contributor

Ill take a look at it.

On Mon, Mar 11, 2013 at 8:28 PM, Chris Beer notifications@github.comwrote:

@ajs6f https://github.com/ajs6f @barmintorhttps://github.com/barmintoram I crazy? could there be a better way?

(also, i'm regretting calling it a RepositoryService.. it's probably a
"LowLevelStorageService" or something. thoughts?)


Reply to this email directly or view it on GitHubhttps://github.com//pull/35#issuecomment-14751832
.

@barmintor
Copy link
Contributor

First question: An InfinispanBinaryStore is a BinaryStore, so there's a dead branch of code, I think. If InfinispanBinaryStore fulfills the getInputStream contract adequately, does that mean that StoreChunkInputStream can just go away?

@cbeer
Copy link
Contributor Author

cbeer commented Mar 12, 2013

Thanks, fixed. I must have switched back to the transient store before running the tests.

Maybe this is a good question for @ajs6f is:

in my test class, I tried to use a different Modeshape repository (but using something other than repo.xml), but there must be a singleton that gets cached somewhere, huh? Or, I saw some weird behavior that made me think it wasn't picking up my repository fix.

@barmintor
Copy link
Contributor

Merging after careful consideration.

barmintor added a commit that referenced this pull request Mar 12, 2013
low-level retrieval of jcr content from the low-level binary stores
@barmintor barmintor merged commit 316432a into master Mar 12, 2013
@cbeer cbeer deleted the ispn-lowlevel-fixity-check branch March 12, 2013 02:39
birkland pushed a commit to birkland/fcrepo4 that referenced this pull request Jul 22, 2016
Allow enabling of internal audit with jetty:run
dbernstein pushed a commit that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants