Pylint fixes #41
Merged
Pylint fixes #41
+24
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding PYTHONPATH, allows linting without having to install the package. * Adding PYTHONWARNINGS=ignore, suppresses the following warnings; ``` /usr/lib/python2.7/inspect.py:65: Warning: g_param_spec_boxed: assertion 'G_TYPE_IS_BOXED (boxed_type)' failed return isinstance(object, (type, types.ClassType)) /usr/lib/python2.7/inspect.py:65: Warning: g_object_class_install_property: assertion 'G_IS_PARAM_SPEC (pspec)' failed return isinstance(object, (type, types.ClassType)) ```
Fixed `Warning: option include-ids is deprecated and ignored.`
|
@hyades poke |
|
@mithro I ran |
|
Did you run "make lint" in the top level directory or in the python-api directory? |
|
@mithro inside gst-switch/python-api. Don't think there is any entry in the top one |
|
Can you paste the complete output of the updated "make lint" target? On 27 November 2014 at 23:18, Aayush Ahuja notifications@github.com wrote:
|
aahuja@ubuntu:~/gst-switch$ cd python-api/
aahuja@ubuntu:~/gst-switch/python-api$ make lint
pylint --rcfile=.pylintrc_gstswitch gstswitch
/usr/lib/python2.7/inspect.py:65: Warning: g_param_spec_boxed: assertion 'G_TYPE_IS_BOXED (boxed_type)' failed
return isinstance(object, (type, types.ClassType))
/usr/lib/python2.7/inspect.py:65: Warning: g_object_class_install_property: assertion 'G_IS_PARAM_SPEC (pspec)' failed
return isinstance(object, (type, types.ClassType))
pylint --rcfile=.pylintrc_unittests tests/unittests/*
************* Module unittests.test_connection_unit
F: 6, 0: Unable to import 'gstswitch.connection' (import-error)
F: 7, 0: Unable to import 'gstswitch.exception' (import-error)
************* Module unittests.test_controller_unit
F: 6, 0: Unable to import 'gstswitch.controller' (import-error)
F: 7, 0: Unable to import 'gstswitch.exception' (import-error)
F: 10, 0: Unable to import 'gstswitch.connection' (import-error)
************* Module unittests.test_helpers_unit
F: 6, 0: Unable to import 'gstswitch.helpers' (import-error)
F: 7, 0: Unable to import 'gstswitch.exception' (import-error)
F: 9, 0: Unable to import 'gstswitch' (import-error)
************* Module unittests.test_server_unit
F: 6, 0: Unable to import 'gstswitch.server' (import-error)
F: 8, 0: Unable to import 'gstswitch.exception' (import-error)
************* Module unittests.test_testsource_unit
F: 6, 0: Unable to import 'gstswitch.exception' (import-error)
F: 7, 0: Unable to import 'gstswitch.testsource' (import-error)
F: 8, 0: Unable to import 'gstswitch.testsource' (import-error)
make: *** [lint] Error 1
aahuja@ubuntu:~/gst-switch/python-api$ |
|
That output shows you are not running with my latest patches. You should have gotten something like; |
|
Works fine. Not sure what happened that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.