-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller for 4 channel DDS used in several ion storage labs. #8
Conversation
In general, to fix PEP8 issues I recommend scanning your python files using the following command: |
Thank you for the comments Yan. I've pushed changes to jboulder/artiq. The only one I don't understand is the first. Do you really need to assign the classname like this? Also, please make changes as required to integrate error/status reporting. I don't yet know about this infrastructure. |
Also, I found that Spyder has this built in...
On Wed, Jan 21, 2015 at 2:38 PM, Yann Sionneau notifications@github.com
|
about the first comment, I had troubles due to the underscore meaning "underline" with markdown markup language. |
I quite recently started using Pycharm which also warns about PEP8 |
Thank you for the many suggestions. I believe I've included them all. Please pull. |
@@ -0,0 +1,362 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
…ning is proper error reporting
…ested by RJ to make it closer to lda driver implementation.
create first stab at example driver per discussion on mailing list https://ssl.serverraum.org/lists-archive/artiq/2014-December/000253.html
create first stab at example driver per discussion on mailing list https://ssl.serverraum.org/lists-archive/artiq/2014-December/000253.html
create first stab at example driver per discussion on mailing list https://ssl.serverraum.org/lists-archive/artiq/2014-December/000253.html
Novatech fixed and merged. Please send updated files/patch for the generic driver and doc edits. |
No description provided.