Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller for 4 channel DDS used in several ion storage labs. #8

Closed
wants to merge 32 commits into from
Closed

Controller for 4 channel DDS used in several ion storage labs. #8

wants to merge 32 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 21, 2015

No description provided.

@fallen
Copy link
Contributor

fallen commented Jan 21, 2015

In general, to fix PEP8 issues I recommend scanning your python files using the following command:
python3 -m flake8 your_file.py
It will show all PEP8 issues.
Or use an IDE which enforces PEP8 and allows automatic reindentation.

@ghost
Copy link
Author

ghost commented Jan 21, 2015

Thank you for the comments Yan. I've pushed changes to jboulder/artiq. The only one I don't understand is the first.

Do you really need to assign the classname like this?
Cannot you do something like obj.class.name if obj is an instance of class Novatech409B?

Also, please make changes as required to integrate error/status reporting. I don't yet know about this infrastructure.

@ghost
Copy link
Author

ghost commented Jan 21, 2015

Also, I found that Spyder has this built in...

  • use a text editor that enforces PEP8
    • Spyder :: Preferences :: Editor :: Code Introspection ::
      • check pyflakes
      • check pep8

On Wed, Jan 21, 2015 at 2:38 PM, Yann Sionneau notifications@github.com
wrote:

In general, to fix PEP8 issues I recommend scanning your python files
using the following command:
python3 -m flake8 your_file.py
It will show all PEP8 issues.


Reply to this email directly or view it on GitHub
#8 (comment).

@fallen
Copy link
Contributor

fallen commented Jan 21, 2015

about the first comment, I had troubles due to the underscore meaning "underline" with markdown markup language.
I meant: obj.__class__.__name__ to retrieve the class name of an instance.

@fallen
Copy link
Contributor

fallen commented Jan 21, 2015

I quite recently started using Pycharm which also warns about PEP8

@ghost
Copy link
Author

ghost commented Jan 24, 2015

Thank you for the many suggestions. I believe I've included them all. Please pull.

@@ -0,0 +1,362 @@
#!/usr/bin/env python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

Joe Britton and others added 28 commits February 2, 2015 18:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ested by RJ to make it closer to lda driver implementation.
@sbourdeauducq
Copy link
Member

Novatech fixed and merged.

Please send updated files/patch for the generic driver and doc edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants