Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
v8: force inlining of v8::internal::DescriptorArray methods
Browse files Browse the repository at this point in the history
  • Loading branch information
piscisaureus committed Jun 11, 2012
1 parent 33be301 commit 2301eb6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions deps/v8/src/objects.h
Expand Up @@ -2530,11 +2530,11 @@ class DescriptorArray: public FixedArray {
void Sort(const WhitenessWitness&);

// Search the instance descriptors for given name.
inline int Search(String* name);
INLINE(int Search(String* name));

// As the above, but uses DescriptorLookupCache and updates it when
// necessary.
inline int SearchWithCache(String* name);
INLINE(int SearchWithCache(String* name));

// Tells whether the name is present int the array.
bool Contains(String* name) { return kNotFound != Search(name); }
Expand Down

3 comments on commit 2301eb6

@ry
Copy link

@ry ry commented on 2301eb6 Jun 11, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did these show up in a profile?

@bnoordhuis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They did for me. gcc 4.4.3 didn't inline them.

@piscisaureus
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ry Quite heavily for me, on windows.

Please sign in to comment.