Skip to content

Commit

Permalink
Minor review updates
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrew Woods committed Oct 26, 2013
1 parent 7d7f27d commit a687165
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
Expand Up @@ -68,7 +68,7 @@ public GraphStoreStreamingOutput(final GraphStore graphStore,
public GraphStoreStreamingOutput(final Dataset dataset,
final MediaType mediaType) {
this.dataset = dataset;
format =
this.format =
contentTypeToLang(mediaType.toString()).getName().toUpperCase();
}

Expand All @@ -81,7 +81,7 @@ public GraphStoreStreamingOutput(final Dataset dataset,
public GraphStoreStreamingOutput(final RdfStream stream,
final MediaType mediaType) {
this.dataset = DatasetFactory.create(stream.asModel());
format =
this.format =
contentTypeToLang(mediaType.toString()).getName().toUpperCase();
}

Expand Down
Expand Up @@ -44,8 +44,7 @@ public class DifferencingIterator<E> extends AbstractIterator<E> {
/**
* Ordinary constructor.
*
* @param notCommon
* @param common
* @param original
* @param source
*/
public DifferencingIterator(final Set<? extends E> original,
Expand Down Expand Up @@ -86,7 +85,7 @@ protected E computeNext() {
*
* @return The elements that turned out to be common to the two inputs.
*/
public Set<E> common() {
protected Set<E> common() {

This comment has been minimized.

Copy link
@ajs6f

ajs6f Oct 26, 2013

Contributor

This is wrong. The whole purpose of this class is to provide access to the results of the calculation, including those elements found in common and not-in-common.

This comment has been minimized.

Copy link
@awoods

awoods Oct 27, 2013

That makes perfect sense. It is not currently being used outside of tests, so I locked it down. Please feel free to push directly to master if you want to open it back up to 'public' now, or just include the revert in your next change-set.

return source.hasNext() ? null : common;
}

Expand All @@ -95,7 +94,7 @@ public Set<E> common() {
*
* @return The elements that turned out not to be common to the two inputs.
*/
public Set<? extends E> notCommon() {
protected Set<? extends E> notCommon() {

This comment has been minimized.

Copy link
@ajs6f

ajs6f Oct 26, 2013

Contributor

See previous note.

return source.hasNext() ? null : notCommon;
}

Expand Down

0 comments on commit a687165

Please sign in to comment.