Speed up removing a node (less block mesh updates).

RealBadAngel · RealBadAngel · commit d0be27415eb9 · 2014-11-08T21:04:30.000+01:00
diff --git a/src/client.cpp b/src/client.cpp
@@ -2300,20 +2300,19 @@ void Client::removeNode(v3s16 p)
 	{
 	}
 	
-	// add urgent task to update the modified node
-	addUpdateMeshTaskForNode(p, false, true);
-
 	for(std::map<v3s16, MapBlock * >::iterator
 			i = modified_blocks.begin();
 			i != modified_blocks.end(); ++i)
 	{
-		addUpdateMeshTaskWithEdge(i->first);
+		addUpdateMeshTask(i->first, false, false);
 	}
+	// add urgent task to update the modified node
+	addUpdateMeshTaskForNode(p, false, true);
 }
 
 void Client::addNode(v3s16 p, MapNode n, bool remove_metadata)
 {
-	TimeTaker timer1("Client::addNode()");
+	//TimeTaker timer1("Client::addNode()");
 
 	std::map<v3s16, MapBlock*> modified_blocks;
 
@@ -2329,7 +2328,7 @@ void Client::addNode(v3s16 p, MapNode n, bool remove_metadata)
 			i = modified_blocks.begin();
 			i != modified_blocks.end(); ++i)
 	{
-		addUpdateMeshTaskWithEdge(i->first);
+		addUpdateMeshTask(i->first, false, false);
 	}
 }
 	

Original file line number	Diff line number	Diff line change
`@@ -2300,20 +2300,19 @@ void Client::removeNode(v3s16 p)`
`2300`	`2300`	`{`
`2301`	`2301`	`}`
`2302`	`2302`
`2303`		`- // add urgent task to update the modified node`
`2304`		`- addUpdateMeshTaskForNode(p, false, true);`
`2305`		`-`
`2306`	`2303`	`for(std::map<v3s16, MapBlock * >::iterator`
`2307`	`2304`	`i = modified_blocks.begin();`
`2308`	`2305`	`i != modified_blocks.end(); ++i)`
`2309`	`2306`	`{`
`2310`		`- addUpdateMeshTaskWithEdge(i->first);`
	`2307`	`+ addUpdateMeshTask(i->first, false, false);`
`2311`	`2308`	`}`
	`2309`	`+ // add urgent task to update the modified node`
	`2310`	`+ addUpdateMeshTaskForNode(p, false, true);`
`2312`	`2311`	`}`
`2313`	`2312`
`2314`	`2313`	`void Client::addNode(v3s16 p, MapNode n, bool remove_metadata)`
`2315`	`2314`	`{`
`2316`		`- TimeTaker timer1("Client::addNode()");`
	`2315`	`+ //TimeTaker timer1("Client::addNode()");`
`2317`	`2316`
`2318`	`2317`	`std::map<v3s16, MapBlock*> modified_blocks;`
`2319`	`2318`
`@@ -2329,7 +2328,7 @@ void Client::addNode(v3s16 p, MapNode n, bool remove_metadata)`
`2329`	`2328`	`i = modified_blocks.begin();`
`2330`	`2329`	`i != modified_blocks.end(); ++i)`
`2331`	`2330`	`{`
`2332`		`- addUpdateMeshTaskWithEdge(i->first);`
	`2331`	`+ addUpdateMeshTask(i->first, false, false);`
`2333`	`2332`	`}`
`2334`	`2333`	`}`
`2335`	`2334`