Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 6eb4d1d15ca8
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: bd8a5755dced
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 5, 2014

  1. src: add default visibility to NODE_MODULE

    It's currently not really possible to compile native add-ons with
    -fvisibility=hidden because that also hides the struct containing
    the module definition.
    
    The NODE_MODULE() and NODE_MODULE_DECL() macros are structured in
    a way that makes it impossible to add a visibility attribute manually
    so there is no escape hatch there.
    
    That's why this commit adds an explicit visibility attribute to
    the module definition.  It doesn't help with node.js releases that
    are already out there but at least it improves the situation going
    forward.
    bnoordhuis authored and indutny committed Mar 5, 2014
    1
    Copy the full SHA
    bd8a575 View commit details
    Browse the repository at this point in the history