Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

v0.11.12 regression: http.Agent instances now *must* specify a protocol field #7349

Closed
TooTallNate opened this issue Mar 24, 2014 · 1 comment
Assignees

Comments

@TooTallNate
Copy link

It appears that I introduced a slight behavior change in d6bbb19, where previously a custom http.Agent instance would not be required to have its own protocol field, now it is mandatory.

This ends up being a problem for custom-defined http.Agent instances that don't necessarily subclass from the core http.Agent class, like my agent-base module.

First reported in TooTallNate/node-proxy-agent#1. I'll have a patch ready shortly.

@TooTallNate
Copy link
Author

See #7351

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant