Fix relationship_list_box() did not print value for [none], [any]

dregad · dregad · commit eacd8401ac9f · 2012-01-20T09:59:22.000+01:00
This caused e.g. a 'duplicate' relationship to be added when cloning a bug, even though '[none]' was selected in the list. This is a regression introduced by 93bbb36 Affects #12450
diff --git a/core/relationship_api.php b/core/relationship_api.php
@@ -777,12 +777,12 @@ function relationship_list_box( $p_default_rel_type = BUG_REL_ANY, $p_select_nam
 	?>
 <select name="<?php echo $p_select_name?>">
 <?php if( $p_include_any ) {?>
-<option value="<?php BUG_REL_ANY ?>" <?php echo( $p_default_rel_type == BUG_REL_ANY ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'any' )?>]</option>
+<option value="<?php echo BUG_REL_ANY ?>" <?php echo( $p_default_rel_type == BUG_REL_ANY ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'any' )?>]</option>
 <?php
 	}
 
 	if( $p_include_none ) {?>
-<option value="<?php BUG_REL_NONE ?>" <?php echo( $p_default_rel_type == BUG_REL_NONE ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'none' )?>]</option>
+<option value="<?php echo BUG_REL_NONE ?>" <?php echo( $p_default_rel_type == BUG_REL_NONE ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'none' )?>]</option>
 <?php
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -777,12 +777,12 @@ function relationship_list_box( $p_default_rel_type = BUG_REL_ANY, $p_select_nam`
`777`	`777`	`?>`
`778`	`778`	`<select name="<?php echo $p_select_name?>">`
`779`	`779`	`<?php if( $p_include_any ) {?>`
`780`		`-<option value="<?php BUG_REL_ANY ?>" <?php echo( $p_default_rel_type == BUG_REL_ANY ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'any' )?>]</option>`
	`780`	`+<option value="<?php echo BUG_REL_ANY ?>" <?php echo( $p_default_rel_type == BUG_REL_ANY ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'any' )?>]</option>`
`781`	`781`	`<?php`
`782`	`782`	`}`
`783`	`783`
`784`	`784`	`if( $p_include_none ) {?>`
`785`		`-<option value="<?php BUG_REL_NONE ?>" <?php echo( $p_default_rel_type == BUG_REL_NONE ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'none' )?>]</option>`
	`785`	`+<option value="<?php echo BUG_REL_NONE ?>" <?php echo( $p_default_rel_type == BUG_REL_NONE ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'none' )?>]</option>`
`786`	`786`	`<?php`
`787`	`787`	`}`
`788`	`788`