New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trunk-3987NEW(1.8.x) #572
trunk-3987NEW(1.8.x) #572
Conversation
I have modified the changes .
@suraj5 is this pull request to be used together with the previous one? or should we close one and take the other? |
@dkayiwa close the first one and take the second one:) |
@suraj5 but the second does not have all your changes in the first one. :) |
@dkayiwa Now I made all the changes. :) |
@suraj5 are using the openmrs formatter here https://wiki.openmrs.org/display/docs/Coding+Conventions#CodingConventions-CodeStyle? Or did you do an "mvn clean install" before committing? It is supposed to correctly format your java files. |
@dkayiwa yes,I downloaded OpenMRS formatting file ,template file into my eclipse and I didnt do any an "mvn clean install" before making changes to "Trunk-3978NEW(1.8.x) |
Can you do it now and then make another formatting commit? |
@dkayiwaI am new to OpenMRS . Let me be clear ,now I should do a mvn clean install on Trunk-3987NEW(1.8.x) and commit it or otherwise should i create a new branch and do a mvn clean install and commit on that. |
@suraj5 after doing mvn clean install, commit to this same pull request for the same branch. This commit will only be a formatting one. |
@dkayiwa Thanks for the reply.I'll do it now.:) |
I have modified the changes asked by you.