make sure broken Expires values are handled gracefully

mojolicious · Jun 1, 2013 · 0bff603 · 0bff603
1 parent 180cf67
commit 0bff603
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/Mojo/Cookie/Response.pm b/lib/Mojo/Cookie/Response.pm
@@ -33,7 +33,7 @@ sub parse {
         my $next = shift @$tree;
         my $rest = shift @$next;
         push @$token, @$next;
-        $value .= ", $rest->[0]";
+        $value .= ", $rest->[0]" if $rest;
       }
 
       # This will only run once

diff --git a/t/mojo/cookie.t b/t/mojo/cookie.t
@@ -361,6 +361,16 @@ is $cookies->[0]->to_string,
   . ' path=/test; secure; Max-Age=60', 'right result';
 is $cookies->[1], undef, 'no more cookies';
 
+# Parse response cookie with broken Expires value
+$cookies = Mojo::Cookie::Response->parse('foo=ba r; Expires=Th');
+is $cookies->[0]->name,  'foo',  'right name';
+is $cookies->[0]->value, 'ba r', 'right value';
+is $cookies->[1], undef, 'no more cookies';
+$cookies = Mojo::Cookie::Response->parse('foo=ba r; Expires=Th; Path=/test');
+is $cookies->[0]->name,  'foo',  'right name';
+is $cookies->[0]->value, 'ba r', 'right value';
+is $cookies->[1], undef, 'no more cookies';
+
 # Response cookie with Max-Age 0 and Expires 0
 $cookie = Mojo::Cookie::Response->new;
 $cookie->name('foo');