Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 89076918f8af
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d3f3ea271f95
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Sep 22, 2014

  1. Unverified

    The committer email address is not verified.
    Copy the full SHA
    f159942 View commit details
  2. Dead code.

    headius committed Sep 22, 2014

    Unverified

    The committer email address is not verified.
    Copy the full SHA
    d3f3ea2 View commit details
Original file line number Diff line number Diff line change
@@ -135,10 +135,6 @@ protected void pre(ThreadContext context, IRubyObject self, String name, Block b
context.setCurrentVisibility(getVisibility());
}

private IRubyObject callJitted(ThreadContext context, IRubyObject self, RubyModule clazz, String name, IRubyObject[] args, Block block) {
return box.actualMethod.call(context, self, clazz, name, args, block);
}

public void ensureInstrsReady() {
// SSS FIXME: Move this out of here to some other place?
// Prepare method if not yet done so we know if the method has an explicit/implicit call protocol
1 change: 0 additions & 1 deletion core/src/main/java/org/jruby/ir/targets/JVMVisitor.java
Original file line number Diff line number Diff line change
@@ -1512,7 +1512,6 @@ public void ReceiveKeywordRestArgInstr(ReceiveKeywordRestArgInstr instr) {

@Override
public void ReceiveOptArgInstr(ReceiveOptArgInstr instr) {
jvmMethod().loadContext();
jvmMethod().loadArgs();
jvmAdapter().pushInt(instr.requiredArgs);
jvmAdapter().pushInt(instr.preArgs);
6 changes: 6 additions & 0 deletions spec/compiler/general_spec.rb
Original file line number Diff line number Diff line change
@@ -853,4 +853,10 @@ class JRUBY4925

expect(x).to eq [1,2,3]
end

it "compiles optional arguments in a method with toplevel rescue" do
x = compile_and_run 'def foo(a = false); raise; rescue; a; end; foo'

expect(x).to eq false
end
end