small optimizations

mojolicious · Feb 6, 2014 · 8381b87 · 8381b87
1 parent 042364c
commit 8381b87
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/lib/Mojo/Util.pm b/lib/Mojo/Util.pm
@@ -308,8 +308,7 @@ sub tablify {
     }
   }
 
-  my $format = join '  ', map {"\%-${_}s"} @spec[0 .. $#spec - 1];
-  $format .= $format ? '  %s' : '%s';
+  my $format = join '  ', map({"\%-${_}s"} @spec[0 .. $#spec - 1]), '%s';
   return join '', map { sprintf "$format\n", @$_ } @$rows;
 }
 
@@ -648,7 +647,7 @@ available through L<Time::HiRes>.
 
   my $table = tablify [['foo', 'bar'], ['baz', 'yada']];
 
-Row-oriented text table builder.
+Row-oriented generator for text tables.
 
   # "foo   bar\nyada  yada\nbaz   yada\n"
   tablify [['foo', 'bar'], ['yada', 'yada'], ['baz', 'yada']];

diff --git a/lib/Mojolicious/Command/routes.pm b/lib/Mojolicious/Command/routes.pm
@@ -14,12 +14,12 @@ sub run {
   GetOptionsFromArray \@args, 'v|verbose' => \my $verbose;
 
   my $rows = [];
-  $self->_walk($_, 0, $rows, $verbose) for @{$self->app->routes->children};
+  _walk($_, 0, $rows, $verbose) for @{$self->app->routes->children};
   print encode('UTF-8', tablify($rows));
 }
 
 sub _walk {
-  my ($self, $route, $depth, $rows, $verbose) = @_;
+  my ($route, $depth, $rows, $verbose) = @_;
 
   # Pattern
   my $prefix = '';
@@ -46,7 +46,7 @@ sub _walk {
   push @$row, $regex if $verbose;
 
   $depth++;
-  $self->_walk($_, $depth, $rows, $verbose) for @{$route->children};
+  _walk($_, $depth, $rows, $verbose) for @{$route->children};
   $depth--;
 }