Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRUNK-3709 Secret answer should be encrypted #800

Closed
wants to merge 1 commit into from
Closed

TRUNK-3709 Secret answer should be encrypted #800

wants to merge 1 commit into from

Conversation

ujjwalarora
Copy link
Member

Used SHA512 hash for hashing secret answer using encodeStringSHA1() in Security,java

@ujjwalarora
TRUNK-3709
141a63a 
TRUNK-3709
@dkayiwa
Copy link
Member

dkayiwa commented Mar 19, 2014

@ujjwalarora did you do mvn clean install and ensure all is well before creating this pull request?

@dkayiwa
Copy link
Member

dkayiwa commented Mar 20, 2014

@ujjwalarora can you create a new pull request while taking note of the tips at http://go.openmrs.org/pull-request-tips?

@dkayiwa dkayiwa closed this Mar 20, 2014
@ujjwalarora
Copy link
Member Author

@dkayiwa : Sure, I will
I realised 1 unit test is failing, I have tried it to solve but stuck on 1 point. Actually, as I have hashed the secret answer in HibernateUserDAO.java, there's 1 test which tries to match secret answer by taking sample password from 'openmrs-core\web\target\test-classes\org\openmrs\web\include\ForgotPasswordFormControllerTest.xml', which is created during the time of unit testing in /target folder and the changes in/target folder are not reflected.

So, can I modify the test. Or is there any other solution ?

@dkayiwa
Copy link
Member

dkayiwa commented Mar 20, 2014

modify and i have a look at it.

On Thu, Mar 20, 2014 at 9:37 PM, ujjwalarora notifications@github.comwrote:

@dkayiwa https://github.com/dkayiwa : Sure, I will
I realised 1 unit test is failing, I have tried it to solve but stuck on 1
point. Actually, as I have hashed the secret answer in
HibernateUserDAO.java, there's 1 test which tries to match secret answer by
taking sample password from
'openmrs-core\web\target\test-classes\org\openmrs\web\include\ForgotPasswordFormControllerTest.xml',
which is created during the time of unit testing in /target folder and the
changes in/target folder are not reflected.

So, can I modify the test. Or is there any other solution ?

Reply to this email directly or view it on GitHubhttps://github.com//pull/800#issuecomment-38204958
.

If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.

@ujjwalarora
Copy link
Member Author

New pull - #807

ujjwalarora referenced this pull request in ujjwalarora/openmrs-core Mar 21, 2014
@ujjwalarora
TRUNK-3709
ddbea46 
TRUNK-3709

updated 1 test in OptionController and skipped 2 in ForgotpasswordForm
TRUNK-3709
@ujjwalarora ujjwalarora mentioned this pull request Apr 10, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ujjwalarora @dkayiwa