Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: joyent/libuv
base: 13f73fadff23
Choose a base ref
...
head repository: joyent/libuv
compare: 3ee4d3f18333
Choose a head ref
  • 1 commit
  • 109 files changed
  • 1 contributor

Commits on Jul 7, 2013

  1. unix, windows: return error codes directly 

    This commit changes the libuv API to return error codes directly rather
than storing them in a loop-global field.

A code snippet like this one:

    if (uv_foo(loop) < 0) {
      uv_err_t err = uv_last_error(loop);
      fprintf(stderr, "%s\n", uv_strerror(err));
    }

Should be rewritten like this:

    int err = uv_foo(loop);
    if (err < 0)
      fprintf(stderr, "%s\n", uv_strerror(err));

The rationale for this change is that it should make creating bindings
for other languages a lot easier: dealing with struct return values is
painful with most FFIs and often downright buggy.
    @bnoordhuis
    bnoordhuis committed Jul 7, 2013
    Copy the full SHA
    3ee4d3f View commit details
    Browse the repository at this point in the history