Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: f2b378b850b3
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: f34757398fcc
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Jan 22, 2015

  1. net: throw on invalid socket timeouts 

    This commit restricts socket timeouts non-negative, finite
numbers. Any other value throws a TypeError or RangeError.
This prevents subtle bugs that can happen due to type
coercion.

Fixes: #8618
PR-URL: #8884
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    @cjihrig
    cjihrig committed Jan 22, 2015
    Copy the full SHA
    f347573 View commit details
    Browse the repository at this point in the history