Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: buildbot/buildbot
base: d64079b8ed0c
Choose a base ref
...
head repository: buildbot/buildbot
compare: d527f19ac820
Choose a head ref
  • 6 commits
  • 2 files changed
  • 2 contributors

Commits on Nov 18, 2014

  1. DockerLatentBuildSlave:

     - Fix: create the container with the name <slavename>_<id>
     - Fix: destroy the container after the stop operation. (Eg: remove from disk)
    Xavier Delannoy committed Nov 18, 2014
    Copy the full SHA
    d738634 View commit details
    Browse the repository at this point in the history
  2. DockerLatentBuildSlave:

     - remove the last \n of log lines when the docker image is built.
    Xavier Delannoy committed Nov 18, 2014
    Copy the full SHA
    e08e431 View commit details
    Browse the repository at this point in the history
  3. DockerLatentBuildSlave

     - remove buildFinished method. It breaks at least:
       - a slave can run several build in parallel.
         with buildFinished, the container is removed as soon as the first build is finished. As a consequence, concurrent build are canceled.
         This is not what we want
       - build_wait_timeout feature
         This is implemented by AbstractLatentBuildSlave
    Xavier Delannoy committed Nov 18, 2014
    Copy the full SHA
    182c6c5 View commit details
    Browse the repository at this point in the history
  4. When using a AbstractLatentBuildSlave with build_wait_timeout >0, thi…

    …s tracback appears when the slave is disconnected when the build_wait_timer fired:
    
    	Traceback (most recent call last):
    	  File "/home/xavierd/Projects/myGitHub/buildbot-work/sandbox/local/lib/python2.7/site-packages/twisted/spread/pb.py", line 1341, in maybeLogout
    	    fn()
    	  File "/home/xavierd/Projects/myGitHub/buildbot-work/src/master/buildbot/pbmanager.py", line 177, in <lambda>
    	    return (pb.IPerspective, persp, lambda: persp.detached(mind))
    	  File "/home/xavierd/Projects/myGitHub/buildbot-work/src/master/buildbot/buildslave/protocols/pb.py", line 104, in detached
    	    self.notifyDisconnected()
    	  File "/home/xavierd/Projects/myGitHub/buildbot-work/src/master/buildbot/buildslave/protocols/base.py", line 43, in notifyDisconnected
    	    self._disconnectSubs.deliver()
    	--- <exception caught here> ---
    	  File "/home/xavierd/Projects/myGitHub/buildbot-work/src/master/buildbot/util/subscription.py", line 37, in deliver
    	    sub.callback(*args, **kwargs)
    	exceptions.TypeError: _disconnected() takes exactly 1 argument (0 given)
    Xavier Delannoy committed Nov 18, 2014
    Copy the full SHA
    9b7d7b5 View commit details
    Browse the repository at this point in the history
  5. autopep8

    Xavier Delannoy committed Nov 18, 2014
    Copy the full SHA
    2653463 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1365 from delanne/DockerLatentFix

    various minor fix for AbstractLatentBuildSlave and DockerLatentBuildSlave
    Mikhail Sobolev committed Nov 18, 2014
    Copy the full SHA
    d527f19 View commit details
    Browse the repository at this point in the history