TRUNK-4230 SonarQube - Inefficient use of keySet iterator instead of ent... #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1013,7 +1013,8 @@ public static void checkCoreDataset() { | |||
| currentRoleNames.add(role.getRole().toUpperCase()); | |||
| } | |||
| Map<String, String> map = OpenmrsUtil.getCoreRoles(); | |||
| for (String roleName : map.keySet()) { | |||
| for (Map.Entry<String, String> entry : map.entrySet()) { | |||
| String roleName = entry.getKey(); | |||
| if (!currentRoleNames.contains(roleName.toUpperCase())) { | |||
| Role role = new Role(); | |||
| role.setRole(roleName); | |||
There was a problem hiding this comment.
The idea of using Entry is that in the line below instead of map.get(roleName) you will call entry.getValue() so that no additional map search is needed. Please do the same in other places.
…entrySet iterator
rkorytkowski
added a commit
that referenced
this pull request
Jan 20, 2014
TRUNK-4230 SonarQube - Inefficient use of keySet iterator instead of entrySet iterator
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rySet iterator