Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USING is not back compatible. #22

Closed
ingydotnet opened this issue Aug 5, 2014 · 2 comments
Closed

USING is not back compatible. #22

ingydotnet opened this issue Aug 5, 2014 · 2 comments

Comments

@ingydotnet
Copy link
Owner

Old usage:

use Inline C => using => 'ParseRecDescent';

New syntax:

use Inline C => using => 'Inline::C::Parser::RecDescent';

Or:

use Inline C => using => 'RecDescent';

We need to provide special support for the 2 old parsers to DTRT:

  • ParseRecDescent
  • ParseRegExp

Maybe with tests :)
@mohawk2
Copy link
Collaborator

mohawk2 commented Aug 5, 2014

Have a hash in Inline::C:
my %OLDPARSER2NEW = qw(ParseRecDescent Inline::C::Parser::RecDescent ParseRegExp Inline::C::Parser::RegExp);

And the USING-handler does:
$class = $OLDPARSER2NEW{$class} || $class;

Big question: USING is currently handled in Inline proper; could Inline::C::validate do the above mapping?

@ingydotnet
Copy link
Owner Author

I think this is handled now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ingydotnet @mohawk2