process: don't use strdup()

file and cwd can be directly used from Utf8Value.
nodejs · Mar 20, 2012 · 253ec6a · 253ec6a
1 parent 415bff2
commit 253ec6a
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/src/process_wrap.cc b/src/process_wrap.cc
@@ -107,9 +107,9 @@ class ProcessWrap : public HandleWrap {
 
     // options.file
     Local<Value> file_v = js_options->Get(String::New("file"));
-    if (!file_v.IsEmpty() && file_v->IsString()) {
-      String::Utf8Value file(file_v->ToString());
-      options.file = strdup(*file);
+    String::Utf8Value file(file_v->IsString() ? file_v : Local<Value>());
+    if (file.length() > 0) {
+      options.file = *file;
     }
 
     // options.args
@@ -128,11 +128,9 @@ class ProcessWrap : public HandleWrap {
 
     // options.cwd
     Local<Value> cwd_v = js_options->Get(String::New("cwd"));
-    if (!cwd_v.IsEmpty() && cwd_v->IsString()) {
-      String::Utf8Value cwd(cwd_v->ToString());
-      if (cwd.length() > 0) {
-        options.cwd = strdup(*cwd);
-      }
+    String::Utf8Value cwd(cwd_v->IsString() ? cwd_v : Local<Value>());
+    if (cwd.length() > 0) {
+      options.cwd = *cwd;
     }
 
     // options.env
@@ -191,9 +189,6 @@ class ProcessWrap : public HandleWrap {
       delete [] options.args;
     }
 
-    free(options.cwd);
-    free((void*)options.file);
-
     if (options.env) {
       for (int i = 0; options.env[i]; i++) free(options.env[i]);
       delete [] options.env;