Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 0d5595ac6026
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: cd96f0aba8fc
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 10, 2013

  1. src: don't SetInternalField() in ObjectWrap dtor

    Call SetPointerInInternalField(0, NULL) rather than
    SetInternalField(0, Undefined()).
    
    Fixes the following spurious NULL pointer dereference in debug builds:
    
      #0  0x03ad2821 in v8::internal::FixedArrayBase::length ()
      #1  0x03ad1dfc in v8::internal::FixedArray::get ()
      #2  0x03ae05dd in v8::internal::Context::global_object ()
      #3  0x03b6b87d in v8::internal::Context::builtins ()
      #4  0x03ae1871 in v8::internal::Isolate::js_builtins_object ()
      #5  0x03ab4fab in v8::CallV8HeapFunction ()
      #6  0x03ab4d4a in v8::Value::Equals ()
      #7  0x03b4f38b in CheckEqualsHelper ()
      #8  0x03ac0f4b in v8::Object::SetInternalField ()
      #9  0x06a99ddd in node::ObjectWrap::~ObjectWrap ()
      #10 0x06a8b051 in node::Buffer::~Buffer ()
      #11 0x06a8afbb in node::Buffer::~Buffer ()
      #12 0x06a8af5e in node::Buffer::~Buffer ()
      #13 0x06a9e569 in node::ObjectWrap::WeakCallback ()
    bnoordhuis committed Apr 10, 2013
    Copy the full SHA
    cd96f0a View commit details
    Browse the repository at this point in the history