Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rustyrussell/pettycoin
base: 7523a44efbbd
Choose a base ref
...
head repository: rustyrussell/pettycoin
compare: cc9b5cb6bfad
Choose a head ref
  • 10 commits
  • 43 files changed
  • 1 contributor

Commits on Oct 29, 2014

  1. tx_len: length function for transactions (replacing marshal_tx_len) 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 29, 2014
    Configuration menu
    Copy the full SHA
    18054bd View commit details
    Browse the repository at this point in the history

  2. tx.c: out-of-line most tx functions. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 29, 2014
    Configuration menu
    Copy the full SHA
    3f6433d View commit details
    Browse the repository at this point in the history

  3. test: add named_blocks common helper. 

    This is reproduced in many test files; unify it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 29, 2014
    Configuration menu
    Copy the full SHA
    40da5da View commit details
    Browse the repository at this point in the history

  4. Makefile: make update-mocks work on clean tree. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 29, 2014
    Configuration menu
    Copy the full SHA
    bf54c2b View commit details
    Browse the repository at this point in the history

  5. valgrind: helper routines. 

    We want to know if memory is undefined earlier, so use explicit calls.
That includes in the packet sending path, as well as the hash functions.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 29, 2014
    Configuration menu
    Copy the full SHA
    f84c5c4 View commit details
    Browse the repository at this point in the history

  6. shadouble helpers: use valgrind helpers. 

    This makes tracking bugs easier.  I added helpers for doing a double-SHA256
all at once, but don't use it everywhere else to avoid churn.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 29, 2014
    Configuration menu
    Copy the full SHA
    2c7647d View commit details
    Browse the repository at this point in the history

  7. packet_io: valgrind check outgoing packets. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 29, 2014
    Configuration menu
    Copy the full SHA
    be16c10 View commit details
    Browse the repository at this point in the history

  8. log: use valgrind helpers on structures. 

    Another chance to catch uninitialized structure elements.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 29, 2014
    Configuration menu
    Copy the full SHA
    2ad9461 View commit details
    Browse the repository at this point in the history

  9. todo: zero another unused field. 

    Switch to using a specific helper for this, as the
PROTOCOL_PKT_GET_TX_IN_BLOCK is a u8, not a u16, so the previous unused
pointer method doesn't work.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 29, 2014
    Configuration menu
    Copy the full SHA
    2deb292 View commit details
    Browse the repository at this point in the history

  10. blockfile: don't do complete chain check if running under valgrind. 

    With any significant number of blocks, it takes far too long.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Oct 29, 2014
    Configuration menu
    Copy the full SHA
    cc9b5cb View commit details
    Browse the repository at this point in the history