Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sample camel projects for integrating Solr #2

Merged
merged 6 commits into from Nov 18, 2014
Merged

added sample camel projects for integrating Solr #2

merged 6 commits into from Nov 18, 2014

Conversation

acoburn
Copy link
Contributor

@acoburn acoburn commented Nov 9, 2014

These are some examples for integrating Solr with a Fedora4 repository using the JAVA and Scala DSLs

@ajs6f
Copy link
Contributor

ajs6f commented Nov 9, 2014

This is a great addition. Two points:

  • We've been using logback for logging in the main codebase, and we might want to stick to that elsewhere.
  • It would be great if "example project" code like this could include integration tests that actually set up an index and put and retrieve stuff from it. I know that that's not always trivial, and I'm not suggesting that we should wait on it, but that could be a ticket for future work.

@acoburn
Copy link
Contributor Author

acoburn commented Nov 9, 2014

Re: logback, I'll start using that. Thanks for the tip.

Re: the integration tests, I still need to add a solr integration test for the main fcrepo-camel code. Once that is set up, I can reuse the same setup. I've added a pivotal story for this: https://www.pivotaltracker.com/s/projects/684825/stories/82351422

@ajs6f
Copy link
Contributor

ajs6f commented Nov 9, 2014

Great! I think that the "message-consumer" project may have some Solr-setup code that could be useful as an example for that.

@awoods
Copy link

awoods commented Nov 18, 2014

Where does this PR stand? Any reason not to merge it?

@acoburn
Copy link
Contributor Author

acoburn commented Nov 18, 2014

It can be merged whenever. I have some more examples to add, but that's no reason to hold this up

awoods pushed a commit that referenced this pull request Nov 18, 2014
added sample camel projects for integrating Solr
@awoods awoods merged commit 623c34e into fcrepo-exts:master Nov 18, 2014
@acoburn acoburn deleted the examples branch January 21, 2015 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants