Fix invalid access denied error caused by access_has_bug_level()

dregad · dregad · commit 9ec47a056156 · 2013-02-27T11:46:41.000+01:00
Commit d42e80c changed the code in access_has_bug_level() function, and introduced a bug as the final call to access_compare_level() inverted the 2 parameters which caused an incorrect return value to be returned in certain cases, incorrectly denying access to issues. Issue #15538
diff --git a/core/access_api.php b/core/access_api.php
@@ -440,7 +440,6 @@ function access_has_bug_level( $p_access_level, $p_bug_id, $p_user_id = null ) {
 				$s_thresholds[$t_project_id] = $t_report_bug_threshold[0];
 			}
 		}
-
 		if( !access_compare_level( $s_thresholds[$t_project_id], $t_access_level ) ) {
 			return false;
 		}
@@ -454,7 +453,7 @@ function access_has_bug_level( $p_access_level, $p_bug_id, $p_user_id = null ) {
 			&& access_compare_level( $t_access_level, $p_access_level );
 	}
 
-	return access_compare_level( $p_access_level, $t_access_level );
+	return access_compare_level( $t_access_level, $p_access_level );
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -440,7 +440,6 @@ function access_has_bug_level( $p_access_level, $p_bug_id, $p_user_id = null ) {`
`440`	`440`	`$s_thresholds[$t_project_id] = $t_report_bug_threshold[0];`
`441`	`441`	`}`
`442`	`442`	`}`
`443`		`-`
`444`	`443`	`if( !access_compare_level( $s_thresholds[$t_project_id], $t_access_level ) ) {`
`445`	`444`	`return false;`
`446`	`445`	`}`
`@@ -454,7 +453,7 @@ function access_has_bug_level( $p_access_level, $p_bug_id, $p_user_id = null ) {`
`454`	`453`	`&& access_compare_level( $t_access_level, $p_access_level );`
`455`	`454`	`}`
`456`	`455`
`457`		`- return access_compare_level( $p_access_level, $t_access_level );`
	`456`	`+ return access_compare_level( $t_access_level, $p_access_level );`
`458`	`457`	`}`
`459`	`458`
`460`	`459`	`/**`