Use of validation class for review / feedback ... Do Not Merge #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by:Spuds <spuds@spudsdesign.com>
! Add ability to sub var names with text in error strings Signed-off-by:Spuds <spuds@spudsdesign.com>
Signed-off-by:Spuds <spuds@spudsdesign.com>
| @@ -819,7 +910,7 @@ protected function _validate_php_syntax($field, $input, $validation_parameters = | |||
| * - Gmail user can use @googlemail.com instead of @gmail.com | |||
| * - Gmail ignores all characters after a + (plus sign) in the username | |||
| * - Gmail ignores all . (dots) in username | |||
| * - ahole@gmail.com, a.hole@gmail.com, ahole+big@gmail.com and a.hole+gigantic@googlemail.com are same email address. | |||
There was a problem hiding this comment.
👼 You can see I was "dealing" with someone when I wrote that .... figured I should improve my comments
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
|
Thanks for providing your feedback TE ... I'm going to close this since the intention was to get input, and I guess I've now got all that. I'll keep a branch in my repo should we decide this is Elk worthy 😉 |
|
Sorry, but these last two weeks have been a bit busy... 😢 And anyway...do you expect meaningful feedback from me apart from: MERGE IMMEDIATELY!!? 👼 |
|
No worries ... TE had some good suggestions that I put in place, now I'm hunting for places I can use it as well as possibly feeding the results to the error class (assuming I don't get distracted by something else 😀 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new checks to the validation class and then puts it to use in one form (email topic). There are several places this can be done but wanted to get feedback if we want to do this and do it in this way.
This was the intention of the class (well my intention), to centralize these types of checks and make adding / changing validation an easy process as well as provide more complete feedback on form data issues.
At some point it seems like this could be linked / report to the error class but thats another refactor at some point.