opal · Nov 10, 2013 · Nov 10, 2013 · Nov 10, 2013
Showing with 9 additions and 11 deletions.

+8 −4 opal/core/enumerable.rb

+0 −7 spec/filters/bugs/enumerable.rb

+1 −0 spec/rubyspecs
diff --git a/opal/core/enumerable.rb b/opal/core/enumerable.rb
@@ -285,6 +285,10 @@ def drop_while(&block)
   def each_slice(n, &block)
     n = Opal.coerce_to n, Integer, :to_int
 
+    if `n <= 0`
+      raise ArgumentError, 'invalid slice size'
+    end
+
     return enum_for :each_slice, n unless block_given?
 
     %x{
@@ -323,8 +327,8 @@ def each_slice(n, &block)
     nil
   end
 
-  def each_with_index(&block)
-    return enum_for :each_with_index unless block_given?
+  def each_with_index(*args, &block)
+    return enum_for :each_with_index, *args unless block_given?
 
     %x{
       var result,
@@ -342,14 +346,14 @@ def each_with_index(&block)
         index++;
       };
 
-      self.$each();
+      self.$each.apply(self, args);
 
       if (result !== undefined) {
         return result;
       }
     }
 
-    nil
+    self
   end
 
   def each_with_object(object, &block)

diff --git a/spec/filters/bugs/enumerable.rb b/spec/filters/bugs/enumerable.rb
@@ -1,13 +1,6 @@
 opal_filter "Enumerable" do
   fails "Enumerable#cycle passed a number n as an argument raises an ArgumentError if more arguments are passed"
 
-  fails "Enumerable#each_slice raises an Argument Error if there is not a single parameter > 0"
-
-  fails "Enumerable#each_with_index provides each element to the block"
-  fails "Enumerable#each_with_index provides each element to the block and its index"
-  fails "Enumerable#each_with_index binds splat arguments properly"
-  fails "Enumerable#each_with_index passes extra parameters to each"
-
   fails "Enumerable#entries passes arguments to each"
 
   fails "Enumerable#first when passed an argument consumes only what is needed"

diff --git a/spec/rubyspecs b/spec/rubyspecs
@@ -116,6 +116,7 @@ core/nil/xor_spec
 
 core/enumerable/all_spec
 core/enumerable/any_spec
+core/enumerable/cycle_spec
 core/enumerable/collect_spec
 core/enumerable/count_spec
 core/enumerable/detect_spec