Trunk 3940 xss in concepts #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
November 15, 2013 23:39
wraps usage of multiple concept and drug related attributes in <c:out ...> tags
dkayiwa
added a commit
that referenced
this pull request
Nov 18, 2013
…n-concepts Trunk 3940 xss in concepts
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bunch of commits should fix TRUNK-3949 and a lot more XSS vulnerabilities altogether.
c:outtags around String type attributes of Concept and related modelsopenmrs:formatmethod for concepts + a new unit test for thathtmlEscape="false".To be honest, I am not 100% sure if this does not influence someone else code in non-core modules but personally I think the white-listing vs. try-to-blacklist-everythingis the right way to go, especially from a security point of view!