Trunk 439 #382
Closed
Trunk 439 #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name in concept tag
TRUNK-439: Add Global property for dashboard header concepts and remove ...
Conflicts: api/src/main/java/org/openmrs/util/OpenmrsConstants.java
| * c.getShortName(loc); if (shortNameVar != null && shortName != null) | ||
| * pageContext.setAttribute(shortNameVar, shortName); | ||
| */ | ||
| if (shortestNameVar != null) { |
There was a problem hiding this comment.
You might want to check if it is not blank, you can use apache commons' StringUtils.isNotBlank(shortedtNameVar)
There was a problem hiding this comment.
I will fix this and commit the code
|
You run the tests by executing sh release-test/release-test.sh from the command line in the root directory of the openmrs project |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
…penmrs#382) * Revert "Revert "Delineate public vs private API of esm-framework (openmrs#376)" (openmrs#381)" This reverts commit 8f3b670. This restores commit 1020f67. * Add missing dependencies to app shell * Add resolve alias to webpack config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is our solution for TRUNK-439. We tested this code manually and with:
mvn clean package
However, we did not manage to run the tests as described in https://wiki.openmrs.org/display/docs/Testing+Releases . Because of this, we could not check our changes in VerifyPatientDashboardSteps.java.
Kind Regards