fixed small drain event bug in Mojo::IOLoop::Stream (closes #491)

mojolicious · May 19, 2013 · 565d075 · 565d075
1 parent d1e9066
commit 565d075
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,6 @@
 
 4.01  2013-05-18
+  - Fixed small drain event bug in Mojo::IOLoop::Stream.
 
 4.0  2013-05-15
   - Code name "Top Hat", this is a major release.

diff --git a/lib/Mojo/IOLoop/Stream.pm b/lib/Mojo/IOLoop/Stream.pm
@@ -41,7 +41,7 @@ sub is_readable {
 
 sub is_writing {
   my $self = shift;
-  return undef unless exists $self->{handle};
+  return undef unless $self->{handle};
   return !!length($self->{buffer}) || $self->has_subscribers('drain');
 }
 
@@ -132,7 +132,7 @@ sub _write {
   }
 
   $self->emit_safe('drain') unless length $self->{buffer};
-  return if $self->is_writing;
+  return if !$self->{handle} || $self->is_writing;
   return $self->close if $self->{graceful};
   $self->reactor->watch($handle, !$self->{paused}, 0);
 }