Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comparing binary key to identifier in assertions #404

Closed
wants to merge 2 commits into from

Conversation

yulgit1
Copy link
Contributor

@yulgit1 yulgit1 commented Jun 2, 2014

changed assertions to match fixity result identifier as a binary key rather than named string

@@ -153,6 +151,6 @@ public void testPolicyDrivenStorage() throws Exception {

e = fixity.iterator().next();

assertThat(e.getStoreIdentifier(), containsString("FileSystemBinaryStore"));
assertEquals(e.getStoreIdentifier(), tiffKey.toString());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails on my Ubuntu machine.

Failed tests:
TiffStoragePolicyStorageIT.testPolicyDrivenStorage:146 expected:<[info://org.modeshape.jcr.value.binary.TransientBinaryStore@75240d4a/tmp/modeshape-binary-store#]3e963d987490dd878426...> but was:<[]3e963d987490dd878426...>

@yulgit1
Copy link
Contributor Author

yulgit1 commented Jun 4, 2014

Pulled latest and still this fails on my Windows OS. This 2nd commit works on windows, maybe it will work on linux too (looks like on linux the identifier has instance info along w/key, so it contains checking key, instead of class name which should be in both)

TiffStoragePolicyStorageIT.testPolicyDrivenStorage(TiffStoragePolicyStorageIT.java:147)
Expected: a string containing "TransientBinaryStore"
but: was "3e963d987490dd8784262d3d42b9807e0afc9729"

@awoods
Copy link

awoods commented Jun 4, 2014

Resolved with: 0319dd1

@awoods awoods closed this Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants