NonUniqueObjectException: a different object with the same identifier

dkayiwa · wluyima · commit a9e1e60d4c9c · 2013-05-12T13:59:15.000-04:00
value was already associated with the session: [org.openmrs.Patient#] -
TRUNK-3728

Applying auto format changes - TRUNK-3728
diff --git a/api/src/main/java/org/openmrs/api/db/hibernate/HibernatePatientDAO.java b/api/src/main/java/org/openmrs/api/db/hibernate/HibernatePatientDAO.java
@@ -177,6 +177,13 @@ private void insertPatientStubIfNeeded(Patient patient) {
 					}
 				}
 			}
+			
+			//Without evicting person, you will get this error when promoting person to patient
+			//org.hibernate.NonUniqueObjectException: a different object with the same identifier
+			//value was already associated with the session: [org.openmrs.Patient#]
+			//see TRUNK-3728
+			Person person = (Person) sessionFactory.getCurrentSession().get(Person.class, patient.getPersonId());
+			sessionFactory.getCurrentSession().evict(person);
 		}
 		
 		// commenting this out to get the save patient as a user option to work correctly
diff --git a/api/src/test/java/org/openmrs/api/PatientServiceTest.java b/api/src/test/java/org/openmrs/api/PatientServiceTest.java
@@ -3379,4 +3379,22 @@ public void savePatient_shouldNotSetAVoidedNameOrAddressOrIdentifierAsPreferred(
 		Assert.assertTrue(address.isPreferred());
 	}
 	
+	/**
+	 * https://tickets.openmrs.org/browse/TRUNK-3728
+	 * 
+	 * @see {@link PatientService#savePatient(Patient)}
+	 */
+	@Test
+	@Verifies(value = "should not throw NonUniqueObjectException when called with person promoted to patient", method = "savePatient(Patient)")
+	public void savePatient_shouldNotThrowNonUniqueObjectExceptionWhenCalledWithPersonPromotedToPatient() throws Exception {
+		Person person = personService.getPerson(1);
+		Patient patient = patientService.getPatientOrPromotePerson(person.getPersonId());
+		PatientIdentifier patientIdentifier = new PatientIdentifier("some identifier", new PatientIdentifierType(2),
+		        new Location(1));
+		patientIdentifier.setPreferred(true);
+		patient.addIdentifier(patientIdentifier);
+		
+		patientService.savePatient(patient);
+	}
+	
 }

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,13 @@ private void insertPatientStubIfNeeded(Patient patient) {`
`177`	`177`	`}`
`178`	`178`	`}`
`179`	`179`	`}`
	`180`	`+`
	`181`	`+ //Without evicting person, you will get this error when promoting person to patient`
	`182`	`+ //org.hibernate.NonUniqueObjectException: a different object with the same identifier`
	`183`	`+ //value was already associated with the session: [org.openmrs.Patient#]`
	`184`	`+ //see TRUNK-3728`
	`185`	`+ Person person = (Person) sessionFactory.getCurrentSession().get(Person.class, patient.getPersonId());`
	`186`	`+ sessionFactory.getCurrentSession().evict(person);`
`180`	`187`	`}`
`181`	`188`
`182`	`189`	`// commenting this out to get the save patient as a user option to work correctly`