Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 8df95d6ad785
Choose a base ref
...
head repository: jruby/jruby
compare: 5ce78c480fa6
Choose a head ref
  • 3 commits
  • 97 files changed
  • 1 contributor

Commits on Nov 12, 2014

  1. Actually apply some formatting to this error.

    @headius
    headius committed Nov 12, 2014
    Copy the full SHA
    5021eb4 View commit details
    Browse the repository at this point in the history

  2. Restructure argv into a single command when doing chdir. 

    JRuby emulates current dir to be a good JVM citizen, since doing
chdir could really mess up other apps/threads running in the same
process. Unfortunately, posix_spawn does not support chdir, so we
restructure the incoming command to use sh with a chdir prepended
to the script. This worked fine for cases where argv only
contained the command to run, but we missed logic to deal with
additional args.

This commit checks for chdir and argc > 1, building a new command
line string by joining the individual argv elements with ' '.

Fix was to get the update_rubygems command working, which does a
Dir.chdir followed by a Kernel#system.
    @headius
    headius committed Nov 12, 2014
    Copy the full SHA
    a467bc5 View commit details
    Browse the repository at this point in the history

  3. Update RubyGems to 2.4.3.

    @headius
    headius committed Nov 12, 2014
    Copy the full SHA
    5ce78c4 View commit details
    Browse the repository at this point in the history