explain what is important when sending a pull request

mojolicious · Nov 21, 2012 · a26cbba · a26cbba
1 parent 8f39242
commit a26cbba
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -1,5 +1,6 @@
 
-3.60  2012-11-21
+3.60  2012-11-22
+  - Improved documentation.
   - Improved tests.
 
 3.59  2012-11-20

diff --git a/lib/Mojolicious/Guides/Contributing.pod b/lib/Mojolicious/Guides/Contributing.pod
@@ -73,6 +73,12 @@ L<Mojolicious wiki|http://github.com/kraih/mojo/wiki>.
 All code contributions should be sent as
 L<GitHub pull requests|https://help.github.com/articles/using-pull-requests>.
 
+An expressive title and detailed description are invaluable during the review
+process, which usually ends when members of the community have voiced their
+opinions and members of the core developer team voted for or against a change.
+All code changes should emulate the style of the surrounding code, include
+tests that fail without them, and update relevant documentation.
+
 While the L<Mojolicious> distribution covers a wide range of features, we are
 rather conservative when it comes to adding new ones. So if your contribution
 is not a bugfix, you can drastically increase its chances of getting accepted