Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 83154aa15db0
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: cbe3941db9ec
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 25, 2013

  1. buffer: slow buffer copy compatibility fix 

    Fix issue where SlowBuffers couldn't be passed as target to Buffer
copy().

Also included checks to see if Argument parameters are defined before
assigning their values. This offered ~3x's performance gain.
    @trevnorris @bnoordhuis
    trevnorris authored and bnoordhuis committed Jan 25, 2013
    Copy the full SHA
    16bbecc View commit details
    Browse the repository at this point in the history

  2. buffer: clean up copy() asserts and tests 

    Argument checks were simplified by setting all undefined/NaN or out of
bounds values equal to their defaults.

Also copy() tests had a flaw that each buffer had the same bit pattern at
the same offset. So even if the copy failed, the bit-by-bit comparison
would have still been true. This was fixed by filling each buffer with a
unique value before copy operations.
    @trevnorris @bnoordhuis
    trevnorris authored and bnoordhuis committed Jan 25, 2013
    Copy the full SHA
    49175e6 View commit details
    Browse the repository at this point in the history

  3. buffer: error and misc cleanup 

    Changed types of errors thrown to be more indicative of what the error
represents. Also removed a few unnecessary uses of the v8 fully
quantified typename.
    @trevnorris @bnoordhuis
    trevnorris authored and bnoordhuis committed Jan 25, 2013
    Copy the full SHA
    cbe3941 View commit details
    Browse the repository at this point in the history