Refactor CRUD in FedoraNodes and FedoraContent for transparent hierarchy support #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the index out-of-bound exception bug in the rest webapp.
Implemented to convert/revert the path for all path segments.
as suggested. Refoctor codes for content files implementation.
transparent auto-hierarchy support.
|
Hi Andrew, |
| @@ -40,7 +40,8 @@ | |||
| * multi-part identifier to ensure efficient performance of the JCR. | |||
| * | |||
| * @author ajs6f | |||
| * @date Mar 26, 2014 | |||
| * @author lsitu | |||
| * @date May 9, 2014 | |||
|
The last commit in this block should be a completely different PR. It does not belong with the first five commits in this changeset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/s/projects/684825/stories/71230608
My local tests showing that the CRUD operations for objects and files are working as expected now. So I think we are ready to move ahead to evaluation the transparent auto-hierarchy feature. Noted that as mentioned during the standup meeting this morning, there are several existing test cases in FedoraNodesTest and FedoraContentTest classes are failed and ignored at this time, which produce a NullPointerException.