improved is_readable performance in Mojo::Reactor

mojolicious · Jul 25, 2014 · 288c2a0 · 288c2a0
1 parent 1924f63
commit 288c2a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,6 @@
 
-5.18  2014-07-24
+5.18  2014-07-25
+  - Improved is_readable performance in Mojo::Reactor.
 
 5.17  2014-07-24
   - Welcome to the Mojolicious core team Jan Henning Thorsen.

diff --git a/lib/Mojo/Reactor.pm b/lib/Mojo/Reactor.pm
@@ -2,7 +2,6 @@ package Mojo::Reactor;
 use Mojo::Base 'Mojo::EventEmitter';
 
 use Carp 'croak';
-use IO::Poll qw(POLLERR POLLHUP POLLIN POLLPRI);
 use Mojo::Loader;
 
 sub again { croak 'Method "again" not implemented by subclass' }
@@ -16,14 +15,8 @@ sub io { croak 'Method "io" not implemented by subclass' }
 
 sub is_readable {
   my ($self, $handle) = @_;
-
-  my $test = $self->{test} ||= IO::Poll->new;
-  $test->mask($handle, POLLIN | POLLPRI);
-  $test->poll(0);
-  my $result = $test->handles(POLLIN | POLLPRI | POLLERR | POLLHUP);
-  $test->remove($handle);
-
-  return !!$result;
+  vec(my $read, fileno($handle), 1) = 1;
+  return !!select $read, undef, $read, 0;
 }
 
 sub is_running { croak 'Method "is_running" not implemented by subclass' }