Eliminate dead code #606
Merged
Eliminate dead code #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protected Node findNode(final Session session, final String path) { | ||
| try { | ||
| // Remove leading and trailing slashes ... | ||
| final String relPath = path.replaceAll("^/+", "").replaceAll("/+$", ""); |
There was a problem hiding this comment.
I think this can be simplified to just:
session.getNode(path)No? I think you might have been confused by the findAndCreate logic, which has to build up the whole tree to the object to find out where to start building nodes from.
There was a problem hiding this comment.
Yes, commit incoming.
|
@barmintor, please add the @SInCE annotation noted in the code comments, then feel free to squash the commits: |
simplify node existence checks in AbstractService and delete commented-out code
ignore checkstyle dot files style conformance in UUIDPidMinter
awoods
pushed a commit
that referenced
this pull request
Oct 30, 2014
Eliminate dead code Related to: https://www.pivotaltracker.com/story/show/80959252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a review of the codebase to eliminate unused code