Likes Suggestion #727
Merged
Likes Suggestion #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove and view style Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
…ve a distinct button for add/remove/view Signed-off-by: Spuds <spuds@spudsdesign.com>
|
Thank you! This is much more like they should behave, to be user-friendly and fit the quick 'click to like this and move on' expectation users of a forum (and other content sharing apps) have. |
|
On a side note, are the former icons still needed? Those that were used for adding and removing a like. |
|
The former ones should not be needed, two were in the sprite and I changed those to the star and one was a standalone that was moved to the sprite (where it should have been) and the standalone removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the likes button from a dropdown selection to a "descriptive" icon ... yeah that's not very descriptive but it was my best short explanation.