fixed small version detection bug in Mojo::Cookie

mojolicious · Aug 26, 2011 · b708006 · b708006
1 parent 84b6dd7
commit b708006
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,8 @@
 This file documents the revision history for Perl extension Mojolicious.
 
+1.93    2011-08-26 00:00:00
+        - Fixed small version detection bug in Mojo::Cookie.
+
 1.92    2011-08-26 00:00:00
         - Improved documentation.
         - Fixed quoting bug in Mojo::Cookie.

diff --git a/lib/Mojo/Cookie/Request.pm b/lib/Mojo/Cookie/Request.pm
@@ -11,7 +11,7 @@ sub parse {
 
   # Walk tree
   my @cookies;
-  my $version = 1;
+  my $version = 0;
   for my $knot ($self->_tokenize($string)) {
     for my $token (@{$knot}) {
       my ($name, $value) = @{$token};

diff --git a/lib/Mojolicious.pm b/lib/Mojolicious.pm
@@ -34,7 +34,7 @@ has static   => sub { Mojolicious::Static->new };
 has types    => sub { Mojolicious::Types->new };
 
 our $CODENAME = 'Smiling Face With Sunglasses';
-our $VERSION  = '1.92';
+our $VERSION  = '1.93';
 
 # "These old doomsday devices are dangerously unstable.
 #  I'll rest easier not knowing where they are."

diff --git a/t/mojo/cookie.t b/t/mojo/cookie.t
@@ -50,23 +50,23 @@ is $cookies->[1], undef, 'no more cookies';
 # Parse request cookies from multiple header values
 $cookie  = Mojo::Cookie::Request->new;
 $cookies = $cookie->parse(
-  '$Version=1; foo=bar; $Path="/test", $Version=2; baz=yada; $Path="/tset"');
+  '$Version=1; foo=bar; $Path="/test", $Version=0; baz=yada; $Path="/tset"');
 is $cookies->[0]->name,    'foo',   'right name';
 is $cookies->[0]->value,   'bar',   'right value';
 is $cookies->[0]->path,    '/test', 'right path';
 is $cookies->[0]->version, '1',     'right version';
 is $cookies->[1]->name,    'baz',   'right name';
 is $cookies->[1]->value,   'yada',  'right value';
 is $cookies->[1]->path,    '/tset', 'right path';
-is $cookies->[1]->version, '2',     'right version';
+is $cookies->[1]->version, '0',     'right version';
 is $cookies->[2], undef, 'no more cookies';
 
 # Parse request cookie (Netscape)
 $cookie  = Mojo::Cookie::Request->new;
 $cookies = $cookie->parse('CUSTOMER=WILE_E_COYOTE');
 is $cookies->[0]->name,    'CUSTOMER',      'right name';
 is $cookies->[0]->value,   'WILE_E_COYOTE', 'right value';
-is $cookies->[0]->version, '1',             'right version';
+is $cookies->[0]->version, '0',             'right version';
 is $cookies->[1], undef, 'no more cookies';
 
 # Parse multiple request cookies (Netscape)
@@ -75,10 +75,10 @@ $cookies =
   $cookie->parse('CUSTOMER=WILE_E_COYOTE; PART_NUMBER=ROCKET_LAUNCHER_0001');
 is $cookies->[0]->name,    'CUSTOMER',             'right name';
 is $cookies->[0]->value,   'WILE_E_COYOTE',        'right value';
-is $cookies->[0]->version, '1',                    'right version';
+is $cookies->[0]->version, '0',                    'right version';
 is $cookies->[1]->name,    'PART_NUMBER',          'right name';
 is $cookies->[1]->value,   'ROCKET_LAUNCHER_0001', 'right value';
-is $cookies->[1]->version, '1',                    'right version';
+is $cookies->[1]->version, '0',                    'right version';
 is $cookies->[2], undef, 'no more cookies';
 
 # Parse multiple request cookies from multiple header values (Netscape)
@@ -87,10 +87,10 @@ $cookies =
   $cookie->parse('CUSTOMER=WILE_E_COYOTE, PART_NUMBER=ROCKET_LAUNCHER_0001');
 is $cookies->[0]->name,    'CUSTOMER',             'right name';
 is $cookies->[0]->value,   'WILE_E_COYOTE',        'right value';
-is $cookies->[0]->version, '1',                    'right version';
+is $cookies->[0]->version, '0',                    'right version';
 is $cookies->[1]->name,    'PART_NUMBER',          'right name';
 is $cookies->[1]->value,   'ROCKET_LAUNCHER_0001', 'right value';
-is $cookies->[1]->version, '1',                    'right version';
+is $cookies->[1]->version, '0',                    'right version';
 is $cookies->[2], undef, 'no more cookies';
 
 # Parse request cookie without value