Don't use _snprintf() on Windows, it's not safe.

_snprintf() doesn't zero-terminate the buffer on overflow. Use the hand-rolled version that lives in src/node_internals.h.
nodejs · May 8, 2012 · 78e831a · 78e831a
1 parent 1eb9fc5
commit 78e831a
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 7 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -31,9 +31,6 @@
 #include <locale.h>
 #include <signal.h>
 #include <stdio.h>
-#if defined(_MSC_VER)
-#define snprintf _snprintf
-#endif
 #include <stdlib.h>
 #include <string.h>
 #if !defined(_MSC_VER)

diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -29,7 +29,6 @@
 
 #include <string.h>
 #ifdef _MSC_VER
-#define snprintf _snprintf
 #define strcasecmp _stricmp
 #endif
 

diff --git a/src/node_extensions.cc b/src/node_extensions.cc
@@ -24,9 +24,6 @@
 #include "node_version.h"
 #include <string.h>
 #include <stdio.h>
-#if defined(_MSC_VER)
-#define snprintf _snprintf
-#endif
 
 #undef NODE_EXT_LIST_START
 #undef NODE_EXT_LIST_ITEM