Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 8a272cabe21d
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 10ccbd501f8a
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 30, 2013

  1. Revert "src: close libuv handles on exit"

    This change is not entirely ready for prime time: it's making ~50 tests
    fail on Windows, mostly due to timeouts.  It's up for debate who is
    at fault here: node.js or libuv.
    
    It does however expose a libuv bug on OS X, where the event loop
    sometimes gets stuck in uv__io_poll() when there is a single
    UV_SHUTDOWN request left in the queue.  Needs further investigation.
    
    This reverts commit 4915884.
    bnoordhuis committed Aug 30, 2013
    Copy the full SHA
    bbed881 View commit details
    Browse the repository at this point in the history
  2. Revert "src: call uv_loop_delete() on exit in debug mode"

    Don't call uv_loop_delete() until we've figured out a way to gracefully
    close open handles.  See also commit 4915884 and its subsequent revert
    in commit 980cbd5.
    
    This reverts commit 556b890.
    bnoordhuis committed Aug 30, 2013
    Copy the full SHA
    10ccbd5 View commit details
    Browse the repository at this point in the history