Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ontology reconciliation #566

Merged
merged 3 commits into from Oct 22, 2014
Merged

Ontology reconciliation #566

merged 3 commits into from Oct 22, 2014

Conversation

escowles
Copy link
Contributor

  • Minor updates to properties used by fcrepo4, mostly updating capitalization and naming conventions to match other properties.

Fixes https://www.pivotaltracker.com/story/show/80959522

@@ -87,7 +87,7 @@ private void concatRepositoryTriples() throws RepositoryException {
for (final String key : repository.getDescriptorKeys()) {
final String descriptor = repository.getDescriptor(key);
if (descriptor != null) {
final String uri = REPOSITORY_NAMESPACE + "repository/" + key;
final String uri = REPOSITORY_NAMESPACE + "repository." + key;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say something more about why we're using . instead of / or #? I imagine it's to make sure we hit a different RDF namespace, but...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REPOSITORY_NAMESPACE ends with a #, so the old URIs had both a # and a / in them, resulting in inconsistencies in what part was considered the namespace. I'm switching to "." to avoid that confusion, the local part will be something like "repository.custom.repo.name".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. +1.

awoods pushed a commit that referenced this pull request Oct 22, 2014
@awoods awoods merged commit 40bf251 into master Oct 22, 2014
@awoods awoods deleted the ontology-reconciliation branch October 22, 2014 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants